Dan Burkert has posted comments on this change. Change subject: [java] Replace interface-annotations with Apache Yetus annotations ......................................................................
Patch Set 7: (1 comment) It looks like most of the imports have been resorted, except in the kudu-client-tools jar. http://gerrit.cloudera.org:8080/#/c/7235/7//COMMIT_MSG Commit Message: PS7, Line 14: This is a binary-incompatible change (but we aren't : guaranteeing binary compatibility). > No worries. Speaking of people with interface annotations in their poms, we My understanding is that this won't break anyone who's doing a from-source rebuild of Kudu using the new version, regardless of whether they are explicitly depending on the interface-annotations jar (I'm not sure why anyone would do that). It _will_ break people who want to swap out the kudu 1.3 jar for the new jar on their classpath without swapping out the old interface jar for the new yetus one. I think that's a sufficiently weird usecase that we shouldn't tie ourselves to it. I've worked at places that tried to maintain binary jar compat between releases, and it end up being a huge headache. -- To view, visit http://gerrit.cloudera.org:8080/7235 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
