Will Berkeley has posted comments on this change. Change subject: [java] Replace interface-annotations with Apache Yetus annotations ......................................................................
Patch Set 8: (1 comment) > I don't see Impala depending on interface-annotations, but I may > have missed it. If this _does_ break Impala, I think we should > rethink. I would consider Impala's usage of the Kudu client to be > typical, and would be very concerned if they have to update > anything. The reason I said that is that the interface-annotations jar ends up packaged with Impala in CDH. Maybe it's a stray, though. http://gerrit.cloudera.org:8080/#/c/7235/7//COMMIT_MSG Commit Message: PS7, Line 14: Projects with dependencies on kudu-client or kudu-spark won't : need to change anything, though if > My understanding is that this won't break anyone who's doing a from-source > regardless of whether they are explicitly depending on the > interface-annotations jar Right. I was assuming people would bump their interface-annotations version, in which case it wouldn't be found since it won't exist anymore. > It _will_ break people who want to swap out the kudu 1.3 jar for the new jar > on their classpath without swapping out the old interface jar for the new > yetus one So if you swap both you're ok? That actually seems like binary compat to me, with the compat breakage being something different that I don't have a name for ("dependency switcheroo"?) -- To view, visit http://gerrit.cloudera.org:8080/7235 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
