Alexey Serbin has uploaded a new patch set (#2).
Change subject: [mini_{master,tablet_server}] webserver binding change
......................................................................
[mini_{master,tablet_server}] webserver binding change
This small patch introduces the following changes for mini_master's and
mini_tablet_server's embedded webserver:
* bind to the 'localhost' interface
* bind to an ephemeral port upon restart
The motivation for this change comes from the flakiness of some tests
observed by the dist-test. Meanwhile, the rationale comes from the fact
that we don't rely on the embedded webserver's port to stay unchanged
on a restart and there is no need to bind the embedded webserver to
external network interfaces while running those tests.
As for details, the tests which restart mini_master and/or
mini_tablet_server sometimes fail with error message like:
Webserver: could not start on address 0.0.0.0:50704: set_ports_option: \
cannot bind to 0.0.0.0:50704: 98 (Address already in use)
With this change, the errors like that should be gone.
Change-Id: I7a655754687badb6870747c18fb44488c68373b2
---
M src/kudu/integration-tests/registration-test.cc
M src/kudu/master/mini_master.cc
M src/kudu/master/mini_master.h
M src/kudu/tserver/mini_tablet_server.cc
4 files changed, 18 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/7266/2
--
To view, visit http://gerrit.cloudera.org:8080/7266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a655754687badb6870747c18fb44488c68373b2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
