Alexey Serbin has posted comments on this change.
Change subject: [mini_{master,tablet_server}] webserver binding change
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7266/2//COMMIT_MSG
Commit Message:
PS2, Line 15: Meanwhile, the rationale comes from the fact
: that we don't rely on the embedded webserver's port to stay
unchanged
: on a restart and there is no need to bind the embedded webserver
to
: external network interfaces while running those tests.
> Are you sure about this? What about tests that use PeriodicWebUIChecker? Ma
Thank you for pointing at the PeriodicWebUIChecker.
I saw that all tests passed in dist-test after this change. It seems we use
PeriodicWebUIChecker only with ExternalMiniCluster, not MiniCluster.
Yep, I think it's a good idea to keep the functionality of the
ExternalMiniCluster and MiniCluster at some parity.
I'll add an option to keep the webserver port the same during restarts for both
the Mini and the ExternalMini clusters.
--
To view, visit http://gerrit.cloudera.org:8080/7266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a655754687badb6870747c18fb44488c68373b2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-HasComments: Yes
