Alexey Serbin has posted comments on this change. Change subject: WIP: Fix SIGSEGV in ksck ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7261/3//COMMIT_MSG Commit Message: PS3, Line 9: the nit: drop http://gerrit.cloudera.org:8080/#/c/7261/3/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: PS3, Line 655: for (const shared_ptr<KsckTabletReplica>& replica : tablet->replicas()) { : replica_infos.emplace_back(); : auto* repl_info = &replica_infos.back(); : repl_info->replica = replica.get(); : VLOG(1) << Substitute("A replica of tablet $0 is on live tablet server $1", : tablet->id(), replica->ts_uuid()); : : // Check for agreement on tablet assignment and state between the master : // and the tablet server. : auto ts = FindPointeeOrNull(cluster_->tablet_servers(), replica->ts_uuid()); BTW, what about entries which might be in cluster_->tablet_servers(), but not present in tablet->replicas()? Or this cannot be the case at all? -- To view, visit http://gerrit.cloudera.org:8080/7261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66ff69bc3aa567863b61ee8e686fc13c81db6fdf Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
