David Ribeiro Alves has submitted this change and it was merged. Change subject: Fix SIGSEGV in ksck ......................................................................
Fix SIGSEGV in ksck ksck will segfault when some tablet servers that host tablet replicas are missing. This happens, for example, if the master is still restarting and has not yet fully populated its list of live tablet servers. The root cause is that a vector of replicas is being sorted by tserver uuid obtained from the master even if the master is not aware of the tablet server was not found, causing a segmentation fault when trying to access the uuid. The fix just checks for a missing tserver reference and sorts such replicas first. The included test segfaults without the fix. Change-Id: I66ff69bc3aa567863b61ee8e686fc13c81db6fdf Reviewed-on: http://gerrit.cloudera.org:8080/7261 Tested-by: Kudu Jenkins Reviewed-by: David Ribeiro Alves <[email protected]> --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc 2 files changed, 17 insertions(+), 2 deletions(-) Approvals: David Ribeiro Alves: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66ff69bc3aa567863b61ee8e686fc13c81db6fdf Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]>
