Alexey Serbin has posted comments on this change. Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7262/2/src/kudu/cfile/rle_block.h File src/kudu/cfile/rle_block.h: PS2, Line 145: . nit: drop the dot PS2, Line 342: . nit: drop the dot :) PS2, Line 340: DCHECK_LE(pos, num_elems_) : << "Tried to seek to " << pos << " which is > number of elements (" : << num_elems_ << ") in the block!."; What would happen in release build if, say, pos == num_elems_ + 1 ? Is it going to be an undefined behavior which would lead to silent data corruption or it's caught by some other sanity check? -- To view, visit http://gerrit.cloudera.org:8080/7262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae72ca1d2af06de1e77cde233e98aa6af97d07e8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
