Andrew Wong has posted comments on this change. Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7262/2/src/kudu/cfile/rle_block.h File src/kudu/cfile/rle_block.h: PS2, Line 342: . > nit: drop the dot :) I don't think there should be data corruption since we're just seeking in the decoder, so it _should_ be harmless. CopyNextValues() ensures that we don't actually copy any data past the end (L403) -- To view, visit http://gerrit.cloudera.org:8080/7262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae72ca1d2af06de1e77cde233e98aa6af97d07e8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
