Todd Lipcon has posted comments on this change. Change subject: tests: IOErrors and IllegalState in TestWorkload ......................................................................
Patch Set 4: (5 comments) consider squashing this into whatever patch relies on it? http://gerrit.cloudera.org:8080/#/c/7243/4//COMMIT_MSG Commit Message: Line 11: helpful in testing disk failure during scans. should we also allow it to use a fault-tolerant scan so we can end-to-end test the fault tolerance property? PS4, Line 14: IllegalState may surface if the disk failed and the tablet : was failed before the scan starts in that case shouldn't it fail over to a different replica? or are these tests running in cases with only a single replica? http://gerrit.cloudera.org:8080/#/c/7243/4/src/kudu/integration-tests/test_workload.cc File src/kudu/integration-tests/test_workload.cc: Line 217: return; why not continue? same below Line 219: if (illegal_state_allowed_ && s.IsIllegalState()) { isn't this redundant? Line 226: if ((io_error_allowed_ && s.IsIOError()) || (illegal_state_allowed_ && s.IsIllegalState())) { maybe it's worth introducing a private boolean function like IsStatusAllowed(const Status& s) ? -- To view, visit http://gerrit.cloudera.org:8080/7243 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364c0ae2ac48920bcbd5b662b931ca448464c90e Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
