Dan Burkert has posted comments on this change. Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS ......................................................................
Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/6635/6/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: PS6, Line 98: the RPC server's certificate " : "private key I think it should just be 'the RPC server's private key file' - it doesn't include a cert. Line 303: [](){ Could this closure be '[&](){' in order to take the flags by reference? http://gerrit.cloudera.org:8080/#/c/6635/6/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: Line 155: // Test making successful RPC calls. Update comment Line 162: CHECK_OK(security::CreateTestSSLCertWithEncryptedKey(GetTestDataDirectory(), Might be worth adding an attempt at passing an incorrect password, just to sanity check that the password checking is working. Line 183: extra newline -- To view, visit http://gerrit.cloudera.org:8080/6635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd6369581fa426ceab11e4a10441658c7da47e81 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
