Alexey Serbin has posted comments on this change. Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6635/6/src/kudu/security/tls_context.cc File src/kudu/security/tls_context.cc: Line 423: const PasswordCallback& password_cb) { Please add SCOPED_OPENSSL_NO_PENDING_ERRORS; in the beginning of this method scope, as everywhere else in this file -- it helps to find issues with non-handled errors while making calls to OpenSSL library functions. PS6, Line 430: Status s = UseCertificateAndKey(c, k); : if (s.ok()) is_external_cert_ = true; : return s; nit: might this be just RETURN_NOT_OK(UseCertificateAndKey(c, k)); is_external_cert_ = true; return Status::OK(); ? It comes with less conditional statements. -- To view, visit http://gerrit.cloudera.org:8080/6635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd6369581fa426ceab11e4a10441658c7da47e81 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
