Todd Lipcon has posted comments on this change.

Change subject: tools: add a tool to extract an arbitrary block to stdout
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7260/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:

Line 378:     const vector<string> kFsDumpModeRegexes = {
> Update this?
Done


http://gerrit.cloudera.org:8080/#/c/7260/1/src/kudu/tools/tool_action_fs.cc
File src/kudu/tools/tool_action_fs.cc:

Line 273:       .Description("Dump the binary contents of a block")
> Maybe "data block" to be more explicit?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7260
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04cf75169b1adb721791ca15b2d5ab5067025f06
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to