Hao Hao has posted comments on this change. Change subject: WIP KUDU-1943: Add BlockTransaction to Block Manager ......................................................................
Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/7207/5/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: Line 326: > warning: the parameter 'block_ids' is copied for each invocation but only u Done http://gerrit.cloudera.org:8080/#/c/7207/6/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: Line 379: TEST_F(LogBlockManagerTest, TestFinalizeBlock) { > error: unknown type name 'BlockManagerTest'; did you mean 'LogBlockManagerT Done Line 379: TEST_F(LogBlockManagerTest, TestFinalizeBlock) { > error: use of undeclared identifier 'BlockManagerTest'; did you mean 'LogBl Done Line 379: TEST_F(LogBlockManagerTest, TestFinalizeBlock) { > error: unknown class name 'BlockManagerTest'; did you mean 'LogBlockManager Done Line 388: ASSERT_EQ(1, bm_->all_containers_by_name_.size()); > error: 'all_containers_by_name_' is a private member of 'kudu::fs::LogBlock Done http://gerrit.cloudera.org:8080/#/c/7207/5/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 48: #include "kudu/util/locks.h" > warning: #includes are not sorted properly [llvm-include-order] Done -- To view, visit http://gerrit.cloudera.org:8080/7207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01f3ed830cc1f86d7bb8a66b2f780914a88884bd Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
