Hao Hao has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager ......................................................................
Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/7207/9/src/kudu/cfile/cfile-test.cc File src/kudu/cfile/cfile-test.cc: Line 38: DECLARE_bool(cfile_close_block_on_finish); > warning: redundant 'FLAGS_block_cache_type' declaration [readability-redund Done http://gerrit.cloudera.org:8080/#/c/7207/9/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: Line 22: #include <kudu/gutil/stl_util.h> > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/7207/9/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 1229: // metadata to disk. > warning: function 'kudu::fs::internal::LogWritableBlock::DoClose' has a def Done -- To view, visit http://gerrit.cloudera.org:8080/7207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01f3ed830cc1f86d7bb8a66b2f780914a88884bd Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
