Grant Henke has posted comments on this change. Change subject: WIP: Add gradle build ......................................................................
Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/7258/2/java/gradle/dependencies.gradle File java/gradle/dependencies.gradle: Line 8: avro : "1.8.1", > ? This is used in the kudu-flume-sink test http://gerrit.cloudera.org:8080/#/c/7258/2/java/gradle/protobuf.gradle File java/gradle/protobuf.gradle: Line 14: // Configure Intellij to see the generated classes > do we need the same for eclipse? yes, we would. There is a decent amount of polish missing from this patch. I didn't want to spend too much time unless we were going to go this route and have this committed. If this initial patch seams reasonable I can touch up the details and remaining todo's. http://gerrit.cloudera.org:8080/#/c/7258/2/java/gradlew File java/gradlew: Line 1: #!/usr/bin/env sh > license This is a generated file by running 'gradle wrapper'. Do generated files have different requirements for license headers? http://gerrit.cloudera.org:8080/#/c/7258/2/java/gradlew.bat File java/gradlew.bat: Line 1: @if "%DEBUG%" == "" @echo off > license This is a generated file by running 'gradle wrapper'. Do generated files have different requirements for license headers? http://gerrit.cloudera.org:8080/#/c/7258/2/java/kudu-flume-sink/build.gradle File java/kudu-flume-sink/build.gradle: Line 1: apply plugin: "com.commercehub.gradle.plugin.avro" > we don't use avro do we? Yes, its used in the AvroKuduOperationsProducer and the tests. http://gerrit.cloudera.org:8080/#/c/7258/2/java/kudu-jepsen/build.gradle File java/kudu-jepsen/build.gradle: Line 38: def masterNodes = project.hasProperty('masterNodes') ? masterNodes : "m0" > does this second masterNodes somehow become equivalent to project.property( you mean using the ext block? That can work too, though this logic may still need to exist to handle passing in parameters that override. I can double check that. http://gerrit.cloudera.org:8080/#/c/7258/2/java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala File java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala: Line 43: object ITBigLinkedList { > why this rename? should we also rename the file then? This is a remnant from accidentally renaming this file and not the test file. Will fix. http://gerrit.cloudera.org:8080/#/c/7258/2/java/kudu-spark/build.gradle File java/kudu-spark/build.gradle: Line 43: } > can we add an 'else' here that fails the build to prevent people from makin Yeah, thats a good idea.This logic may change a bit when I wrap up generating all variations of this artifact in the main build call instead of depending on parameters. -- To view, visit http://gerrit.cloudera.org:8080/7258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
