Grant Henke has posted comments on this change. Change subject: WIP: Add gradle build ......................................................................
Patch Set 2: (3 comments) I am happy to add extremely thorough comments to the build. http://gerrit.cloudera.org:8080/#/c/7258/2/java/build.gradle File java/build.gradle: Line 9: subprojects { > What motivated this decomposition? Is it idiomatic for gradle? Or just some Its a bit of both. Its fairly common practice. You can see that pattern used quite a bit in the gradle project itself: https://github.com/gradle/gradle/tree/master/gradle Line 11: apply from: "$rootDir/gradle/scopes.gradle" > Can these be sorted alphabetically? If not, could you add comments to expla I can add a comment on the order. I load them in the order they are "needed" or used for a build. I find its a nice way to order the scripts. It also helps avoid any configuration or plugin dependency issues. http://gerrit.cloudera.org:8080/#/c/7258/2/java/gradlew File java/gradlew: Line 1: #!/usr/bin/env sh > If it's a generated file, why are we checking it in? Shouldn't it just be r The point of this file is to prevent the need for a gradle install on the box running the build. Without it a gradle install is needed to generate all the necessary files to run the wrapper. And if you have gradle installed much of the benefit of the wrapper goes away. This would be re-generated anytime we upgrade the gradle version the project is built with. I am happy to answer more questions on this and you can read more about the wrapper here: https://docs.gradle.org/4.0/userguide/gradle_wrapper.html -- To view, visit http://gerrit.cloudera.org:8080/7258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
