Mike Percy has posted comments on this change. Change subject: KUDU-1932. Run at least one tablet-level test against all block managers ......................................................................
Patch Set 6: Code-Review+1 (3 comments) Looking pretty good, just some minor comments now http://gerrit.cloudera.org:8080/#/c/7252/6/src/kudu/integration-tests/ts_recovery-itest.cc File src/kudu/integration-tests/ts_recovery-itest.cc: Line 79: vector<string> extra_tserver_flags_ = {}; nit: not a big deal but typically leave a blank line between your method declarations and your variable declarations. A good example is here: https://google.github.io/styleguide/cppguide.html#Class_Format PS6, Line 151: nit: not your fault, but since you need to go back and address the Tidy Bot comments anyway, mind removing this trailing space from this line? Line 189: extra_tserver_flags_with_crash.push_back("--fault_crash_during_log_replay=0.05"); > warning: use emplace_back instead of push_back [modernize-use-emplace] emplace_back() is preferred when constructing an object. In this case, we're implicitly constructing a std::string (since that's what the vector holds) from a string literal (which is a const* char). -- To view, visit http://gerrit.cloudera.org:8080/7252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bf8c4ef45d907f17366776dace9fecd95120821 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Edward Fancher <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Edward Fancher <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
