Edward Fancher has posted comments on this change. Change subject: KUDU-1932. Run at least one tablet-level test against all block managers ......................................................................
Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/7252/5//COMMIT_MSG Commit Message: PS5, Line 8: > This is a good one too: https://chris.beams.io/posts/git-commit/ Thanks. Can't beat a blog where they use xkcd references. :) http://gerrit.cloudera.org:8080/#/c/7252/6/src/kudu/integration-tests/ts_recovery-itest.cc File src/kudu/integration-tests/ts_recovery-itest.cc: Line 79: vector<string> extra_tserver_flags_ = {}; > nit: not a big deal but typically leave a blank line between your method de Done PS6, Line 151: > nit: not your fault, but since you need to go back and address the Tidy Bot Done Line 189: extra_tserver_flags_with_crash.push_back("--fault_crash_during_log_replay=0.05"); > warning: use emplace_back instead of push_back [modernize-use-emplace] Done Line 189: extra_tserver_flags_with_crash.push_back("--fault_crash_during_log_replay=0.05"); > emplace_back() is preferred when constructing an object. In this case, we'r Yes. I think it also has stronger checks. It was giving me a runtime error when I tried to use it the way I would with a python style push, which allows you to concatenate lists. I only got an error at runtime with push_back. Line 237: extra_tserver_flags_.push_back("--log_segment_size_mb=1"); > warning: use emplace_back instead of push_back [modernize-use-emplace] Done Line 238: extra_tserver_flags_.push_back("--log_compression_codec=NO_COMPRESSION"); > warning: use emplace_back instead of push_back [modernize-use-emplace] Done -- To view, visit http://gerrit.cloudera.org:8080/7252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bf8c4ef45d907f17366776dace9fecd95120821 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Edward Fancher <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Edward Fancher <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
