Todd Lipcon has posted comments on this change. Change subject: java: add a new test for multiple sessions on a single client ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7361/1/java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java File java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java: Line 149: OperationResponse apply = s.apply(u); > FWIW apply() can also send exceptions. that's OK - it'll still end up getting caught in the catch clause on line 64 PS1, Line 164: LOG.info("Upserted {} rows", numUpserted.get()); > nit: does it make sense to add verification on the expected number of upser the test runs for a prescribed amount of time, rather than a prescribed number of upserts, so hard to assert on much here -- To view, visit http://gerrit.cloudera.org:8080/7361 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife7f02b160d4635e8acb0155c98a1ef9c3dbab5e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
