Alexey Serbin has posted comments on this change. Change subject: util: add Status::AndThen combinator ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7399/2//COMMIT_MSG Commit Message: PS2, Line 11: RETURN_NOT_OK As an alternative, could Status::AndThen's functionality be implemented as macro as well? Like RETURN_NOT_OK_CLEANUP(TryDoSomething(), Rollback()) ? http://gerrit.cloudera.org:8080/#/c/7399/2/src/kudu/util/status.h File src/kudu/util/status.h: PS2, Line 172: {.cpp} This is redundant: it's inferred from the file this sample is located, so it's 'cpp' already. PS2, Line 172: \ nit: I think it would be nice to keep the @-like notation here: @code PS2, Line 180: \ nit: ditto the comment style -- it would be better to have @endcode here -- To view, visit http://gerrit.cloudera.org:8080/7399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6e1a79ff95406825d4238a8157d242252562805 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
