Dan Burkert has posted comments on this change. Change subject: util: add Status::AndThen combinator ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7399/1/src/kudu/util/status.h File src/kudu/util/status.h: Line 178: /// .CloneAndPrepend("failed to write to example file"); > this pattern seems a little suspect because it always eager-evaluates the a Yes. In this case it's more-or-less zero cost since it's a static Slice, but if it were a Substitute or similar it may be expensive. -- To view, visit http://gerrit.cloudera.org:8080/7399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6e1a79ff95406825d4238a8157d242252562805 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
