Edward Fancher has posted comments on this change. Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover ......................................................................
Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/7456/2//COMMIT_MSG Commit Message: Line 7: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover > nit: Avoid period at end of subject line in a commit message Fixed. http://gerrit.cloudera.org:8080/#/c/7456/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java: Line 42: * This test writes 3 rows, kills the leader, then tries to write another 3 rows. Finally it > nit: line length should be <= 100 chars Done. Line 49: KuduSession session = syncClient.newSession(); > Can we keep the existing simple test and add an additional test that uses t Done Line 51: session.apply(createBasicSchemaInsert(table, i)); > style: use final and all caps for constants Done Line 67: scanner = client.newScannerBuilder(table).build(); > I find this logic a bit difficult to follow. I'd suggest keeping a counter Done Line 77 > these assertions should probably be assert eventually Done -- To view, visit http://gerrit.cloudera.org:8080/7456 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie93a15084a4c4c0748dc74c005b8313f443a5ba9 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Edward Fancher <[email protected]> Gerrit-Reviewer: Edward Fancher <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
