Edward Fancher has posted comments on this change. Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover ......................................................................
Patch Set 6: (9 comments) http://gerrit.cloudera.org:8080/#/c/7456/5/java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java: PS5, Line 35: lon > it's typical to use a long for millisecond time values in Java Done PS5, Line 64: NUM_ITERAT > still named OUTER_LOOP, see comments on rev 4 Done PS5, Line 71: DEFAU > Better to not use magic numbers. For consistency with the rest of the clien Done PS5, Line 89: yet > no need to say "yet" here, RYW will always be optional Done PS5, Line 90: DEFAU > DEFAULT_SLEEP Done PS5, Line 93: DEFAU > use DEFAULT_SLEEP here and elsewhere Done http://gerrit.cloudera.org:8080/#/c/7456/5/java/kudu-client/src/test/java/org/apache/kudu/util/AssertHelpers.java File java/kudu-client/src/test/java/org/apache/kudu/util/AssertHelpers.java: PS5, Line 27: > This is a standard Java thing and not required to be mentioned here Done Line 28: public static void assertEventuallyTrue(String description, BooleanExpression expression, > No need to give credit for this. Flume is ASL 2.0 which doesn't require att Done PS5, Line 36: > would be nice to avoid calling 'get()' twice, in case it's expensive. For e Better? -- To view, visit http://gerrit.cloudera.org:8080/7456 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie93a15084a4c4c0748dc74c005b8313f443a5ba9 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Edward Fancher <e...@cloudera.com> Gerrit-Reviewer: Edward Fancher <e...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
