Todd Lipcon has posted comments on this change.

Change subject: fixed getRole() to return Role
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7495/1//COMMIT_MSG
Commit Message:

Line 7: fixed getRole() to return Role
please follow our commit formatting guidelines (see 
https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines
 for best practices)


http://gerrit.cloudera.org:8080/#/c/7495/1/java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java
File java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java:

Line 128:     public Role getRole() {
this is a public API so you can't make this change without breaking users.

For the purpose of this patch you'll probably need to add a new 
package-protected getter for the role enum


-- 
To view, visit http://gerrit.cloudera.org:8080/7495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1be0f7b1ea845e3ee7dffdab11ae63a0d91f464b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: [email protected]
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to