Michael Ho has posted comments on this change. Change subject: KUDU-2065: Support cancellation for outbound RPC call ......................................................................
Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/7455/3/src/kudu/rpc/connection.h File src/kudu/rpc/connection.h: PS3, Line 280: MayBe > nit: "Maybe" is one word rather than "MayBe" Done http://gerrit.cloudera.org:8080/#/c/7455/3/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: Line 448: if (controller.call_) { > under what circumstance would controller not have a 'call_' member set? Wou Done http://gerrit.cloudera.org:8080/#/c/7455/3/src/kudu/rpc/messenger.h File src/kudu/rpc/messenger.h: PS3, Line 199: const RpcController& > I think taking this by pointer makes more sense since it "mutates" the stat This interface is removed in the latest patch. http://gerrit.cloudera.org:8080/#/c/7455/3/src/kudu/rpc/outbound_call.h File src/kudu/rpc/outbound_call.h: PS3, Line 264: triggeres > typo Done PS3, Line 266: reference > typo: references Done http://gerrit.cloudera.org:8080/#/c/7455/2/src/kudu/rpc/proxy.cc File src/kudu/rpc/proxy.cc: Line 106: << "It is illegal to call set_user_credentials() after request processing has started"; > yea, it's a little messy vs having it directly in RpcController. Did you co Implemented RpcController::Cancel() in the latest patch. -- To view, visit http://gerrit.cloudera.org:8080/7455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf53c5b113de10d573bd32fb9b2293572e806fbf Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
