Michael Ho has posted comments on this change. Change subject: KUDU-2065: Support cancellation for outbound RPC call ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/7455/4/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: Line 966: // The payload to be used during the RPC. > can you introduce a constant for this payload size since the magic number 2 Done Line 982: int idx; > maybe use a Random instance here? (util/random.h) to randomize the sleep be Done http://gerrit.cloudera.org:8080/#/c/7455/4/src/kudu/rpc/rpc_controller.h File src/kudu/rpc/rpc_controller.h: PS4, Line 227: This function should only be : // called when there is an outstanding ou > I think this doc should be clarified a bit to include the following importa Thanks for pointing them out. They are indeed important details to document. -- To view, visit http://gerrit.cloudera.org:8080/7455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf53c5b113de10d573bd32fb9b2293572e806fbf Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
