Dan Burkert has posted comments on this change. Change subject: [WIP]log block manager: mark container as 'read_only' after syncing error ......................................................................
Patch Set 12: (1 comment) 1 small comment, but otherwise LGTM. I'd like to give Adar a chance to look it over as well. http://gerrit.cloudera.org:8080/#/c/7374/8/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 1206: return Status::OK(); > One thing is that if FlushData() fail, we may not necessarily need to mark oh I see, that's very subtle. Could you add a comment to that effect above the FlushData(..) call? -- To view, visit http://gerrit.cloudera.org:8080/7374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15062b9d82c9cb563fb6bb2af7ec89da5f71e28f Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
