Adar Dembo has posted comments on this change. Change subject: log block manager: mark container as read-only after syncing error ......................................................................
Patch Set 17: (2 comments) http://gerrit.cloudera.org:8080/#/c/7374/17/src/kudu/fs/block_manager-test.cc File src/kudu/fs/block_manager-test.cc: Line 843: // Regression test for KUDU-1793. So just to be clear, if you revert your fix, this test fails reliably? Or fails somewhat often (given 1000 runs or something like that)? Line 887: I think you can consolidate more work here. Prepare one buffer, sized to 'size'. Do one Read() to fill it up. Then, do the kNumAppends loop. Inside it, based on the overall size, CHECK_EQ against kShortTestData or kLongTestData. -- To view, visit http://gerrit.cloudera.org:8080/7374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15062b9d82c9cb563fb6bb2af7ec89da5f71e28f Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
