Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1865: Avoid heap allocation for payload slices ......................................................................
KUDU-1865: Avoid heap allocation for payload slices As shown in KUDU-1865, the heap allocation for the temporary vector for the slices for holding the serialized payload is introducing measurable overhead under heavy load. This change replaces the heap allocation with a stack allocation of an array of size TransferLimits::kMaxPayloadSlices. With this change, we saw 10%~15% improvement under heavy workload. Change-Id: I4470d34ba48db5edaeb66d9e739e0c8942004d86 Reviewed-on: http://gerrit.cloudera.org:8080/7471 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> --- M src/kudu/rpc/connection.cc M src/kudu/rpc/connection.h M src/kudu/rpc/inbound_call.cc M src/kudu/rpc/inbound_call.h M src/kudu/rpc/outbound_call.cc M src/kudu/rpc/outbound_call.h M src/kudu/rpc/transfer.cc M src/kudu/rpc/transfer.h 8 files changed, 59 insertions(+), 48 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4470d34ba48db5edaeb66d9e739e0c8942004d86 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
