Andrew Wong has posted comments on this change. Change subject: disk failure: coordinate error handling ......................................................................
Patch Set 25: (6 comments) http://gerrit.cloudera.org:8080/#/c/7029/24/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: Line 272: > missing a word? You're right that this belongs in the next patch. http://gerrit.cloudera.org:8080/#/c/7029/24/src/kudu/fs/fs_manager.h File src/kudu/fs/fs_manager.h: PS24, Line 125: // relevant DataDir's UUID as its input parameter. > I think it's clearer to have this information with the typedef of ErrorNoti Done Line 130: // This must be called before the callback's callee is destroyed. Calls to > nit: can you add whether this is idempotent? safe to call if nothing is set Done http://gerrit.cloudera.org:8080/#/c/7029/24/src/kudu/fs/log_block_manager.h File src/kudu/fs/log_block_manager.h: PS24, Line 169: d 'error_ > what's this mean? I don't think this line adds much value since the fact th Fair point, had it for symmetry with file_block_manager. I'll just remove these lines and leave the below as notes. Line 195: FRIEND_TEST(LogBlockManagerTest, TestMetadataTruncation); > is this used? tried grepping for it and didn't see any call sites, but mayb Yeah, used in a future patch. Moved. http://gerrit.cloudera.org:8080/#/c/7029/24/src/kudu/tserver/ts_tablet_manager.h File src/kudu/tserver/ts_tablet_manager.h: Line 189: void FailTabletsInDataDir(const std::string& uuid); > nit: std::string in header Done -- To view, visit http://gerrit.cloudera.org:8080/7029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3169deada702c527b70fabf9d2223364f9a9ea6 Gerrit-PatchSet: 25 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
