Adar Dembo has posted comments on this change. Change subject: disk failure: coordinate error handling ......................................................................
Patch Set 20: (1 comment) http://gerrit.cloudera.org:8080/#/c/7029/20/src/kudu/tserver/tablet_server.cc File src/kudu/tserver/tablet_server.cc: Line 141: fs_manager_->UnsetErrorNotificationCb(); Nit: move this down to just before tablet_manager_->Shutdown() so it's clear that the two are related. -- To view, visit http://gerrit.cloudera.org:8080/7029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3169deada702c527b70fabf9d2223364f9a9ea6 Gerrit-PatchSet: 20 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
