Adar Dembo has posted comments on this change. Change subject: log block manager: mark container as read-only after syncing error ......................................................................
Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/7374/18/src/kudu/fs/block_manager-test.cc File src/kudu/fs/block_manager-test.cc: PS18, Line 892: if (kNumAppends * kShortTestData.size() == size) { : for (int i = 0; i < kNumAppends; i++) { : CHECK_EQ(kShortTestData, : data.substr(i * kShortTestData.size(), kShortTestData.size())); : } : } else { : CHECK_EQ(kNumAppends * kLongTestData.size(), size); : for (int i = 0; i < kNumAppends; i++) { : CHECK_EQ(kLongTestData, : data.substr(i * kLongTestData.size(), kLongTestData.size())); : } : } Rewrite as: const string* string_to_check = kNumAppends * kShortTestData.size() == size ? kShortTestData : kLongTestData; for (int i = 0; i < kNumAppends; i++) { CHECK_EQ(*string_to_check, data.substr(i * string_to_check->size(), string_to_check->size())); } -- To view, visit http://gerrit.cloudera.org:8080/7374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15062b9d82c9cb563fb6bb2af7ec89da5f71e28f Gerrit-PatchSet: 18 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
