Todd Lipcon has submitted this change and it was merged.

Change subject: tool: print usage information when arguments fail to parse
......................................................................


tool: print usage information when arguments fail to parse

This changes the output when the user forgets to pass a required
argument such that the usage string is now returned.

Example:

  todd@va1022:~/kudu$ build/latest/bin/kudu fs dump block
  Invalid argument: must provide positional argument block_id

  Usage: build/latest/bin/kudu fs dump block <block_id>
  [-fs_wal_dir=<dir>] [-fs_data_dirs=<dirs>]

Change-Id: I4695aca5cb3f848f525784476403a9f577fdba13
Reviewed-on: http://gerrit.cloudera.org:8080/7301
Reviewed-by: Adar Dembo <[email protected]>
Tested-by: Kudu Jenkins
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action.cc
M src/kudu/tools/tool_action.h
M src/kudu/tools/tool_main.cc
4 files changed, 39 insertions(+), 16 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7301
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4695aca5cb3f848f525784476403a9f577fdba13
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>

Reply via email to