Todd Lipcon has posted comments on this change. Change subject: Move clock-related classes to src/kudu/clock ......................................................................
Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/7519/4/src/kudu/clock/CMakeLists.txt File src/kudu/clock/CMakeLists.txt: PS4, Line 19: hybrid_clock.cc : logical_clock.cc) > Nit: indentation Done http://gerrit.cloudera.org:8080/#/c/7519/4/src/kudu/clock/hybrid_clock.h File src/kudu/clock/hybrid_clock.h: Line 17: #pragma once > Mind updating the rest of clock/* to use this? Done http://gerrit.cloudera.org:8080/#/c/7519/4/src/kudu/consensus/log-test-base.h File src/kudu/consensus/log-test-base.h: Line 62: using consensus::NO_OP; > Nit: resort Done http://gerrit.cloudera.org:8080/#/c/7519/3/src/kudu/integration-tests/consistency-itest.cc File src/kudu/integration-tests/consistency-itest.cc: Line 61: using kudu::clock::HybridClock; > Nit: resort Done http://gerrit.cloudera.org:8080/#/c/7519/3/src/kudu/integration-tests/ts_recovery-itest.cc File src/kudu/integration-tests/ts_recovery-itest.cc: PS3, Line 62: using clock::Clock; : using clock::HybridClock; > Nit: resort Done http://gerrit.cloudera.org:8080/#/c/7519/5/src/kudu/tablet/tablet_bootstrap-test.cc File src/kudu/tablet/tablet_bootstrap-test.cc: PS5, Line 59: using clock::Clock; : using clock::LogicalClock; > PS4 had the right sort order. woops... what did I do... thanks -- To view, visit http://gerrit.cloudera.org:8080/7519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4f49be6944ec636387f0c9f5721355402e51fc2 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
