Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7628
to look at the new patch set (#2).
Change subject: remove 'using std::...' and other from header files
......................................................................
remove 'using std::...' and other from header files
Adding 'using ...' into header files is not a good idea. In particular,
it confuses the include-what-you-use tool so it gives strange and
incorrect suggestions. Most likely, there is a bug in the tool as is,
but let's at least not contradict our C++ style guide and remove those
'using ...' from the header files.
This patch does not contain any functional changes.
Change-Id: Iea777af2d881abdb593f9e6f667e613cca8b2fd3
---
M src/kudu/benchmarks/tpch/line_item_tsv_importer.h
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/benchmarks/wal_hiccup.cc
M src/kudu/cfile/binary_prefix_block.cc
M src/kudu/cfile/block_pointer.h
M src/kudu/cfile/bloomfile-test-base.h
M src/kudu/cfile/bloomfile-test.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
M src/kudu/cfile/encoding-test.cc
M src/kudu/cfile/index-test.cc
M src/kudu/cfile/index_block.cc
M src/kudu/cfile/index_block.h
M src/kudu/cfile/index_btree.cc
M src/kudu/cfile/mt-bloomfile-test.cc
M src/kudu/cfile/plain_block.h
M src/kudu/cfile/type_encodings.cc
M src/kudu/client/batcher.cc
M src/kudu/client/client-test-util.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/scanner-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/table-internal.cc
M src/kudu/clock/hybrid_clock-test.cc
M src/kudu/clock/hybrid_clock.cc
M src/kudu/clock/logical_clock.cc
M src/kudu/codegen/row_projector.h
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/column_predicate.cc
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/encoded_key.cc
M src/kudu/common/encoded_key.h
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/generic_iterators.cc
M src/kudu/common/generic_iterators.h
M src/kudu/common/iterator.h
M src/kudu/common/key_encoder.cc
M src/kudu/common/key_util-test.cc
M src/kudu/common/partial_row-test.cc
M src/kudu/common/partial_row.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition.h
M src/kudu/common/partition_pruner.cc
M src/kudu/common/row.h
M src/kudu/common/row_changelist-test.cc
M src/kudu/common/row_changelist.cc
M src/kudu/common/row_changelist.h
M src/kudu/common/row_operations-test.cc
M src/kudu/common/row_operations.cc
M src/kudu/common/scan_spec-test.cc
M src/kudu/common/scan_spec.cc
M src/kudu/common/scan_spec.h
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/common/timestamp.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/common/wire_protocol-test-util.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/common/wire_protocol.h
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/log_anchor_registry-test.cc
M src/kudu/consensus/log_cache-test.cc
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/log_index.cc
M src/kudu/consensus/log_reader.cc
M src/kudu/consensus/log_util.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/consensus/time_manager-test.cc
M src/kudu/consensus/time_manager.cc
M src/kudu/fs/block_manager.h
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/fs/fs-test-util.h
M src/kudu/fs/fs_manager.cc
M src/kudu/gutil/int128.h
M src/kudu/gutil/map-util.h
M src/kudu/gutil/stl_util.h
M src/kudu/gutil/stringprintf.cc
M src/kudu/gutil/stringprintf.h
M src/kudu/gutil/strings/escaping.cc
M src/kudu/gutil/strings/escaping.h
M src/kudu/gutil/strings/human_readable.cc
M src/kudu/gutil/strings/human_readable.h
M src/kudu/gutil/strings/join.cc
M src/kudu/gutil/strings/join.h
M src/kudu/gutil/strings/numbers.h
M src/kudu/gutil/strings/serialize.h
M src/kudu/gutil/strings/split.cc
M src/kudu/gutil/strings/split.h
M src/kudu/gutil/strings/split_internal.h
M src/kudu/gutil/strings/strcat.cc
M src/kudu/gutil/strings/strcat.h
M src/kudu/gutil/strings/stringpiece.h
M src/kudu/gutil/strings/strip.h
M src/kudu/gutil/strings/substitute.cc
M src/kudu/gutil/strings/substitute.h
M src/kudu/gutil/strings/util.h
M src/kudu/gutil/strtoint.h
M src/kudu/gutil/type_traits.h
M src/kudu/gutil/walltime.cc
M src/kudu/gutil/walltime.h
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/client-negotiation-failover-itest.cc
M src/kudu/integration-tests/client-stress-test.cc
M src/kudu/integration-tests/cluster_itest_util.h
M src/kudu/integration-tests/cluster_verifier.cc
M src/kudu/integration-tests/cluster_verifier.h
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
M src/kudu/integration-tests/exactly_once_writes-itest.cc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/internal_mini_cluster.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/master_migration-itest.cc
M src/kudu/integration-tests/master_replication-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/ts_itest-base.h
M src/kudu/integration-tests/ts_recovery-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/integration-tests/update_scan_delta_compact-test.cc
M src/kudu/master/catalog_manager-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master-path-handlers.cc
M src/kudu/master/master-test-util.h
M src/kudu/master/master-test.cc
M src/kudu/master/master.cc
M src/kudu/master/sys_catalog-test.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/sys_catalog.h
M src/kudu/master/ts_descriptor.cc
M src/kudu/rpc/exactly_once_rpc-test.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/mt-rpc-test.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/rpc/negotiation.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/remote_method.cc
M src/kudu/rpc/request_tracker.cc
M src/kudu/rpc/result_tracker.cc
M src/kudu/rpc/result_tracker.h
M src/kudu/rpc/retriable_rpc.h
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc.cc
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/rpc/rpcz_store.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/rpc/sasl_common.h
M src/kudu/rpc/server_negotiation.cc
M src/kudu/rpc/service_pool.cc
M src/kudu/security/cert-test.cc
M src/kudu/security/cert.cc
M src/kudu/security/openssl_util.cc
M src/kudu/security/openssl_util.h
M src/kudu/security/openssl_util_bio.h
M src/kudu/security/simple_acl.cc
M src/kudu/security/test/mini_kdc.cc
M src/kudu/security/tls_context.cc
M src/kudu/security/token-test.cc
M src/kudu/server/default-path-handlers.cc
M src/kudu/server/pprof-path-handlers.cc
M src/kudu/server/rpc_server-test.cc
M src/kudu/server/rpcz-path-handler.cc
M src/kudu/server/tracing-path-handlers.cc
M src/kudu/server/webserver-test.cc
M src/kudu/server/webui_util.cc
M src/kudu/tablet/all_types-scan-correctness-test.cc
M src/kudu/tablet/cbtree-test.cc
M src/kudu/tablet/cfile_set-test.cc
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/compaction.h
M src/kudu/tablet/compaction_policy.cc
M src/kudu/tablet/composite-pushdown-test.cc
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tablet/delta_compaction.cc
M src/kudu/tablet/delta_iterator_merger.h
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/delta_stats.cc
M src/kudu/tablet/delta_store.cc
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltafile.h
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/deltamemstore.h
M src/kudu/tablet/diskrowset-test-base.h
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/key_value_test_schema.h
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tablet/lock_manager.cc
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/memrowset.h
M src/kudu/tablet/mock-rowsets.h
M src/kudu/tablet/mt-rowset_delta_compaction-test.cc
M src/kudu/tablet/multi_column_writer.cc
M src/kudu/tablet/mutation.cc
M src/kudu/tablet/mutation.h
M src/kudu/tablet/mvcc.cc
M src/kudu/tablet/mvcc.h
M src/kudu/tablet/row_op.cc
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/rowset.h
M src/kudu/tablet/rowset_info.cc
M src/kudu/tablet/rowset_metadata.cc
M src/kudu/tablet/rowset_metadata.h
M src/kudu/tablet/rowset_tree-test.cc
M src/kudu/tablet/rowset_tree.cc
M src/kudu/tablet/svg_dump.cc
M src/kudu/tablet/tablet-harness.h
M src/kudu/tablet/tablet-pushdown-test.cc
M src/kudu/tablet/tablet-schema-test.cc
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet-test-util.h
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_history_gc-test.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_mm_ops-test.cc
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/transactions/alter_schema_transaction.cc
M src/kudu/tablet/transactions/transaction_driver.cc
M src/kudu/tablet/transactions/transaction_tracker.cc
M src/kudu/tablet/transactions/write_transaction.cc
M src/kudu/tools/color.cc
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/kudu-ts-cli-test.cc
M src/kudu/tools/tool_action.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tools/tool_action_pbc.cc
M src/kudu/tools/tool_action_tserver.cc
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/scanners.cc
M src/kudu/tserver/scanners.h
M src/kudu/tserver/tablet_copy-test-base.h
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_copy_service-test.cc
M src/kudu/tserver/tablet_copy_service.cc
M src/kudu/tserver/tablet_copy_service.h
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_copy_source_session.cc
M src/kudu/tserver/tablet_server-test-base.h
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager-test.cc
M src/kudu/tserver/ts_tablet_manager.h
M src/kudu/tserver/tserver-path-handlers.cc
M src/kudu/twitter-demo/insert_consumer.cc
M src/kudu/twitter-demo/parser-test.cc
M src/kudu/twitter-demo/parser.cc
M src/kudu/twitter-demo/twitter-schema.h
M src/kudu/twitter-demo/twitter_streamer.cc
M src/kudu/twitter-demo/twitter_streamer.h
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/compression/compression_codec.cc
M src/kudu/util/crc-test.cc
M src/kudu/util/debug-util.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/env-test.cc
M src/kudu/util/env_posix.cc
M src/kudu/util/env_util-test.cc
M src/kudu/util/env_util.cc
M src/kudu/util/failure_detector.cc
M src/kudu/util/file_cache-stress-test.cc
M src/kudu/util/flags.cc
M src/kudu/util/group_varint-test.cc
M src/kudu/util/interval_tree-test.cc
M src/kudu/util/kernel_stack_watchdog.cc
M src/kudu/util/knapsack_solver-test.cc
M src/kudu/util/locks.cc
M src/kudu/util/locks.h
M src/kudu/util/maintenance_manager-test.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/memcmpable_varint-test.cc
M src/kudu/util/memory/arena-test.cc
M src/kudu/util/memory/arena.h
M src/kudu/util/memory/memory.h
M src/kudu/util/mt-metrics-test.cc
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
M src/kudu/util/net/sockaddr.cc
M src/kudu/util/net/socket.cc
M src/kudu/util/nvm_cache.cc
M src/kudu/util/object_pool.h
M src/kudu/util/oid_generator.cc
M src/kudu/util/os-util.cc
M src/kudu/util/pb_util.h
M src/kudu/util/protoc-gen-insertions.cc
M src/kudu/util/random-test.cc
M src/kudu/util/spinlock_profiling-test.cc
M src/kudu/util/stopwatch.h
M src/kudu/util/thread.cc
M src/kudu/util/threadpool.cc
M src/kudu/util/trace.cc
340 files changed, 1,376 insertions(+), 1,168 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/7628/2
--
To view, visit http://gerrit.cloudera.org:8080/7628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea777af2d881abdb593f9e6f667e613cca8b2fd3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
