Adar Dembo has posted comments on this change.

Change subject: rpc: hook up a callback for libev fatal errors
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7633/2//COMMIT_MSG
Commit Message:

PS2, Line 17: It's difficult to write an automated test for this, but I tested 
by
            : setting my ulimit to 10 and running rpc-test.
What about using setrlimit(RLIMIT_NOFILE, ...) to drop the max number of open 
fds? Here's some test code I wrote to play around with that: 
https://gist.github.com/adembo/fba94e3956a8db4ad45d3fce91106c6b.

Alternatively, what about creating an unbounded number of Messengers in a loop? 
That would work if each one makes libev  create a pipe.


-- 
To view, visit http://gerrit.cloudera.org:8080/7633
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5fa77237a40f43d6bb82e9f1ceecd31d52268f9d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to