Todd Lipcon has submitted this change and it was merged. Change subject: rpc: hook up a callback for libev fatal errors ......................................................................
rpc: hook up a callback for libev fatal errors In troubleshooting a recent cluster issue, I found that the daemon had run out of file descriptors. This caused libev to abort(), but the error message wasn't anywhere obvious since the default implementation just writes to stderr. Piping this through to a GLog FATAL is more likely to result in an obvious log message. It's difficult to write an automated test for this, but I tested by setting my ulimit to 10 and running rpc-test. This resulted in: F0809 19:03:39.882194 3358 reactor.cc:108] LibEV fatal error: (libev) error creating signal/async pipe: Too many open files [24] Change-Id: I5fa77237a40f43d6bb82e9f1ceecd31d52268f9d Reviewed-on: http://gerrit.cloudera.org:8080/7633 Tested-by: Kudu Jenkins Reviewed-by: Matthew Jacobs <[email protected]> Reviewed-by: David Ribeiro Alves <[email protected]> --- M src/kudu/rpc/reactor.cc 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: David Ribeiro Alves: Looks good to me, approved Matthew Jacobs: Looks good to me, but someone else must approve Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fa77237a40f43d6bb82e9f1ceecd31d52268f9d Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon <[email protected]>
