Adar Dembo has posted comments on this change.

Change subject: Run the gradle build as a part of the gerrit tests
......................................................................


Patch Set 5:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/7651/5/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

Line 56: #   BUILD_JAVA        Default: 1
Update this comment to reflect that this builds the Java sources with Maven.


Line 75: # 
Gerrit flagged some extra whitespace here and below.


Line 78: #     Java tests.
Hmm, but we're not using gradle to run tests, just to build. Is this intended 
to be a future-proof comment?


Line 385:   # Rerun the build using the Gradle build. 
Can we break this out of BUILD_JAVA so that you could run build-and-test.sh 
with BUILD_JAVA=0 and BUILD_GRADLE=1?


-- 
To view, visit http://gerrit.cloudera.org:8080/7651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <granthe...@gmail.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to