Grant Henke has posted comments on this change. Change subject: Run the gradle build as a part of the gerrit tests ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/7651/5/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: Line 56: # BUILD_JAVA Default: 1 > Update this comment to reflect that this builds the Java sources with Maven I think eventually we would switch to either maven or gradle and not continue to have both since the maintenance of keeping them in sync is high. My though is to leave BUILD_JAVA generic and just have BUILD_GRADLE as an option until we swap completely. Line 78: # Java tests. > Hmm, but we're not using gradle to run tests, just to build. Is this intend I can change this. Mainly a copy paste error. Line 385: # Rerun the build using the Gradle build. > Can we break this out of BUILD_JAVA so that you could run build-and-test.sh See my other commend above. I think BUILD_JAVA should wrap BUILD_GRADLE since at some point we will remove maven and BUILD_JAVA will essentially become BUILD_GRADLE. -- To view, visit http://gerrit.cloudera.org:8080/7651 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
