Todd Lipcon has posted comments on this change.

Change subject: rpc: move ConnectionId to its own file
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7685/1//COMMIT_MSG
Commit Message:

PS1, Line 10: which didn't
> nit: which _it_ didn't  ?
Done


http://gerrit.cloudera.org:8080/#/c/7685/1/src/kudu/rpc/proxy.h
File src/kudu/rpc/proxy.h:

PS1, Line 26: #include "kudu/rpc/outbound_call.h"
> still needed?
nope, good catch.


-- 
To view, visit http://gerrit.cloudera.org:8080/7685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5343c2f6ad305b5927d71457d5d19e3799052ec9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to