Sailesh Mukil has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7687/4/src/kudu/master/ts_descriptor.cc File src/kudu/master/ts_descriptor.cc: Line 246: RETURN_NOT_OK(ResolveSockaddr(&addr, &host)); In cases like this, wouldn't addr.ToStringWithoutPort() be the same as 'host'? Are we just trying to avoid another reverse DNS lookup by doing this? http://gerrit.cloudera.org:8080/#/c/7687/4/src/kudu/util/net/sockaddr.cc File src/kudu/util/net/sockaddr.cc: PS4, Line 102: char str[INET_ADDRSTRLEN]; : ::inet_ntop(AF_INET, &addr_.sin_addr, str, INET_ADDRSTRLEN); : return StringPrintf("%s:%d", str, port()); return StringPrintf("%s:%d", ToStringWithoutPort(), port()); -- To view, visit http://gerrit.cloudera.org:8080/7687 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96fb3c73382f0be6e30e29ae2e7176be42f3bb98 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
