Sailesh Mukil has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies ......................................................................
Patch Set 5: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/7687/5/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: PS5, Line 675: master_proxy_.reset(new MasterServiceProxy( : messenger_, leader_addr, leader_addr.host())); nit: single line. http://gerrit.cloudera.org:8080/#/c/7687/5/src/kudu/integration-tests/create-table-stress-test.cc File src/kudu/integration-tests/create-table-stress-test.cc: PS5, Line 105: master_proxy_.reset(new MasterServiceProxy( : messenger_, addr, addr.host())); nit: single line. http://gerrit.cloudera.org:8080/#/c/7687/5/src/kudu/integration-tests/master-stress-test.cc File src/kudu/integration-tests/master-stress-test.cc: PS5, Line 245: unique_ptr<MasterServiceProxy> proxy( : new MasterServiceProxy(messenger, addr, addr.host())); nit: single line http://gerrit.cloudera.org:8080/#/c/7687/4/src/kudu/master/ts_descriptor.cc File src/kudu/master/ts_descriptor.cc: Line 246: RETURN_NOT_OK(ResolveSockaddr(&addr, &host)); > addr.ToStringWithoutPort is always the dotted-decimal string '1.2.3.4' rath Thanks for clarifying. -- To view, visit http://gerrit.cloudera.org:8080/7687 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96fb3c73382f0be6e30e29ae2e7176be42f3bb98 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
