Alexey Serbin has posted comments on this change. Change subject: [build-support] IWYU build configuration for Jenkins ......................................................................
Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/7750/8/CMakeLists.txt File CMakeLists.txt: PS8, Line 119: # Generate a Clang compile_commands.json "compilation database" file for use : # with various development tools, such as Vim's YouCompleteMe plugin. : # See http://clang.llvm.org/docs/JSONCompilationDatabase.html : if ("$ENV{CMAKE_EXPORT_COMPILE_COMMANDS}" STREQUAL "1") : set(CMAKE_EXPORT_COMPILE_COMMANDS 1) : endif() > Don't need this anymore? Yep -- I didn't expect we had this already. I looked into the .ycm_extra_conf.py and I think it does not require updating. If the compilation database file is not present or it's just removed, the script will use that no-file-exist branch, but otherwise it will use the generated JSON file to open the compilation database. Line 1058: # "make iwyu" target > Should we provide two targets like with lint, where one is 'incremental' an I thought about that and decided to not introduce the full variant -- it seemed to me that the full would work too slow. To make the full run, there is another way of doing so via CMAKE_CXX_INCLUDE_WHAT_YOU_USE. The problem is that the iwyu_tool.py cannot run the independent commands in parallel. http://gerrit.cloudera.org:8080/#/c/7750/8/build-support/iwyu/iwyu.sh File build-support/iwyu/iwyu.sh: Line 23: trap "rm -f $IWYU_LOG" EXIT > Does this remove IWYU_LOG on the various "exit 0" and "exit 1" paths out of As I understand, this works for any type of exit from the script. Line 52: tee $IWYU_LOG > If we're removing IWYU_LOG on exit, what's the point of redirecting to it a That's for easier testing that the filtered output from IWYU is empty -- see the check below. I'm always open for better alternatives, of course. Line 60: exit 0 > When this path is taken, is there enough console output to make it clear wh I think it would be better to add some more. -- To view, visit http://gerrit.cloudera.org:8080/7750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45f2e8529891dd7da18c9fa6383e0c41e6b4182e Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
