Adar Dembo has posted comments on this change. Change subject: [build-support] IWYU build configuration for Jenkins ......................................................................
Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/7750/8/CMakeLists.txt File CMakeLists.txt: PS8, Line 119: endif() : : ############################################################ : # Compiler flags : ############################################################ : > Yep -- I didn't expect we had this already. But this part of .ycm_extra_conf.py is no longer needed, since it'll now always happen: # You can get CMake to generate this file for you by adding: # set( CMAKE_EXPORT_COMPILE_COMMANDS 1 ) # to your CMakeLists.txt file. http://gerrit.cloudera.org:8080/#/c/7750/8/build-support/iwyu/iwyu.sh File build-support/iwyu/iwyu.sh: Line 52: tee $IWYU_LOG > That's for easier testing that the filtered output from IWYU is empty -- se Ah, gotcha. -- To view, visit http://gerrit.cloudera.org:8080/7750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45f2e8529891dd7da18c9fa6383e0c41e6b4182e Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
