Hao Hao has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager ......................................................................
Patch Set 22: (7 comments) http://gerrit.cloudera.org:8080/#/c/7207/21/src/kudu/fs/block_manager-test.cc File src/kudu/fs/block_manager-test.cc: PS21, Line 522: Random rand(SeedRandom()); : vector<unique_ptr<WritableBlock>> dirty_bl > This is no longer true and can be removed, right? Right. Removed. http://gerrit.cloudera.org:8080/#/c/7207/21/src/kudu/fs/file_block_manager.cc File src/kudu/fs/file_block_manager.cc: Line 63: DECLARE_bool(block_manager_lock_dirs); > Not needed anymore? Done http://gerrit.cloudera.org:8080/#/c/7207/21/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 79: DECLARE_bool(enable_data_block_fsync); > Can be removed. Done PS21, Line 528: ck is ful > , marking Done PS21, Line 905: > Use DCHECK_EQ Done PS21, Line 1054: e conta > depending Done PS21, Line 1054: n isn' > place Done -- To view, visit http://gerrit.cloudera.org:8080/7207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01f3ed830cc1f86d7bb8a66b2f780914a88884bd Gerrit-PatchSet: 22 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
