Adar Dembo has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager ......................................................................
Patch Set 23: (10 comments) http://gerrit.cloudera.org:8080/#/c/7207/23/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: PS23, Line 325: enum SyncMode { : SYNC, : NO_SYNC : }; No longer needed? PS23, Line 1219: Do Doing PS23, Line 1219: it in Line 1220: // unmanaged blocks which leaves gaps in data files. But the unmanaged "unmanaged" isn't really an existing concept. How about "Doing nothing can result in data-consuming gaps in containers, but these gaps can be cleaned up by hole repunching at start up"? Line 1223: // orphan blocks if the metadata is durable. But orphan blocks can be orphaned PS23, Line 1226: abortion abort PS23, Line 1227: abortion abort Line 1228: // avoid large chunk of useless consumed space and unmanaged blocks. A "chunks" and "data-consuming gaps". PS23, Line 1230: abortion abort PS23, Line 1232: abortion abort -- To view, visit http://gerrit.cloudera.org:8080/7207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01f3ed830cc1f86d7bb8a66b2f780914a88884bd Gerrit-PatchSet: 23 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
