Todd Lipcon has posted comments on this change.

Change subject: raft_consensus-itest: robust fix for asynchronous kill
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7561/5//COMMIT_MSG
Commit Message:

Line 20: repeatedly ping the paused server until it stops responding.
one idea for an even more general solution that addresses this problem 
everywhere instead of at each call site:

what if ExternalDaemon::Pause() polled /proc/<pid>/status waiting for the 
process state to be 'T' (stopped)? it's not osx-compatible but I don't think we 
are really worried about 0.1% flakes on osx.


-- 
To view, visit http://gerrit.cloudera.org:8080/7561
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99d400e971d6f9b22cc7b4483db94a98ec306e10
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to