Andrew Wong has posted comments on this change.

Change subject: Kudu Consistency Blog Post Pt1
......................................................................


Patch Set 10:

(22 comments)

http://gerrit.cloudera.org:8080/#/c/7019/10/_posts/2017-08-21-kudu-consistency-pt1.md
File _posts/2017-08-21-kudu-consistency-pt1.md:

PS10, Line 8: some of 
nit: remove


PS10, Line 25: single machine
single-machine


PS10, Line 25: e thread
single-threaded


PS10, Line 26: m
add comma


PS10, Line 32:  single-threaded, single-machine storage
consider removing?


PS10, Line 34: s
add comma


PS10, Line 35: , which
This sentence is getting long; consider starting a new one.


PS10, Line 36: in 
on


PS10, Line 39: '
> Is this a well-known quote?
If the idea here is to emphasize, consider using italics or bold, if it's a 
quote, use double-quotes.
If neither, remove the surrounding punctuation marks.


PS10, Line 47:  in 
unbold the "in" here and below


PS10, Line 68: , i.e. reads,
Consider surrounding with ()s instead of commas, same below. The commas sort of 
break the sentence apart making it a bit more difficult to parse.


PS10, Line 71:  with right set
with the right


PS10, Line 73: (Spanner achieves 5 9's availability)
Not sure if this tidbit is important unless we're planning on bringing it up 
later.
Or maybe link to a definition


Line 73: cases (Spanner achieves 5 9's availability). For the write path, we 
often made similar choices in Kudu.
of


PS10, Line 75: informed
directed?


PS10, Line 79: factor
remove


PS10, Line 94:  much higher in the priority scale
a much higher priority


PS10, Line 137: a
remove


PS10, Line 143: get/set _timestamp tokens_ from/to
coordinate a set of _timestamp tokens_ with clients


PS10, Line 145: __STRICT SERIALIZABILITY__
Is there a reason these are caps'ed and bolded? consider lower-case and 
italicized, since it seems these are concepts that are being introduced here.


PS10, Line 145: __LINEARIZABILITY__ and
              : __SERIALIZABILITY__
perhaps link to a definition?


PS10, Line 146: g the user pass messages from/to clients
              : with the timestamp tokens
having the user coordinate the timestamp tokens across clients


-- 
To view, visit http://gerrit.cloudera.org:8080/7019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icaec0c8ace20651a65901a8e1786e785265540d1
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-HasComments: Yes

Reply via email to