Hao Hao has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager ......................................................................
Patch Set 24: (11 comments) http://gerrit.cloudera.org:8080/#/c/7207/22/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: PS22, Line 283: return Status::OK(); : } : > nit: It seems superfluous to specify = default here, particularly since the Done http://gerrit.cloudera.org:8080/#/c/7207/23/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: PS23, Line 325: static const char* kMagic; : : // Creates a new block container in 'dir'. : st > No longer needed? Done PS23, Line 1219: Do > Doing Done PS23, Line 1219: lt > in Done Line 1220: // data-consuming gaps in containers, but these gaps can be cleaned up > "unmanaged" isn't really an existing concept. How about "Doing nothing can Done Line 1223: // orphaned blocks if the metadata is durable. But orphaned blocks can be > orphaned Done PS23, Line 1226: abort ha > abort Done PS23, Line 1227: abort ha > abort Done Line 1228: // avoid large chunks of data-consuming gaps and orphaned blocks. A > "chunks" and "data-consuming gaps". Done PS23, Line 1230: abort, i > abort Done PS23, Line 1232: abort, D > abort Done -- To view, visit http://gerrit.cloudera.org:8080/7207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01f3ed830cc1f86d7bb8a66b2f780914a88884bd Gerrit-PatchSet: 24 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
