Adar Dembo has posted comments on this change. Change subject: [cmake] introduce 'pb-gen' and 'krpc-gen' targets ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7777/2/CMakeLists.txt File CMakeLists.txt: PS2, Line 634: source&header Nit: source/header, or "source and header" Line 637: function(KUDU_PROTOBUF_GENERATE_CPP SRCS HDRS TGTS) FWIW, FindProtobuf.cmake is already a heavily-modified form of cmake's original file. Meaning, I don't think you necessarily need to isolate these changes from PROTOBUF_GENERATE_CPP; I think it'd be fine to modify PROTOBUF_GENERATE_CPP directly. Same goes for KRPC_GENERATE, which is definitely Kudu-specific. PS2, Line 659: source&header same -- To view, visit http://gerrit.cloudera.org:8080/7777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48833098553ef7d3f4fae8b88079cb354b52bea1 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
